Label deletion #68
Merged
Label deletion #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #68 +/- ##
==========================================
- Coverage 72.09% 72.04% -0.05%
==========================================
Files 32 32
Lines 12175 12248 +73
Branches 2181 2205 +24
==========================================
+ Hits 8777 8824 +47
+ Misses 1090 1079 -11
- Partials 2308 2345 +37
Continue to review full report at Codecov.
|
rrooij
approved these changes
Apr 15, 2021
| @@ -288,83 +290,71 @@ async fn get_label_from_exclusive_locked_file<P: Into<PathBuf>>( | |||
| Ok((label, file)) | |||
| } | |||
|
|
|||
| #[async_trait] | |||
| let mut p = self.path.clone(); | ||
| p.push(format!("{}.label", name)); | ||
|
|
||
| // We're not locking here to remove the file. The assumption |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code for deleting labels.
Closes #8, and contributes to #56.