Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support inverted index for sparse vector #517

Merged
merged 21 commits into from
Aug 2, 2024
Merged

feat: support inverted index for sparse vector #517

merged 21 commits into from
Aug 2, 2024

Conversation

kemingy
Copy link
Member

@kemingy kemingy commented Jul 4, 2024 •
edited
Loading

@kemingy kemingy marked this pull request as ready for review July 12, 2024 06:20
@kemingy
rebase
4e619c8 
Signed-off-by: Keming <[email protected]>
@kemingy
adopt the reranker
7bbd3c6 
Signed-off-by: Keming <[email protected]>
@kemingy
rebase
72c791e 
Signed-off-by: Keming <[email protected]>
@kemingy kemingy requested a review from usamoi July 23, 2024 07:46
usamoi
usamoi reviewed Jul 23, 2024
View reviewed changes
crates/index/Cargo.toml Show resolved Hide resolved
crates/base/src/index.rs Outdated Show resolved Hide resolved
crates/base/src/vector/svecf32.rs Outdated Show resolved Hide resolved
crates/inverted/src/lib.rs Outdated Show resolved Hide resolved
crates/inverted/src/lib.rs Outdated Show resolved Hide resolved
crates/inverted/src/lib.rs Outdated Show resolved Hide resolved
@kemingy
address commments
64df757 
Signed-off-by: Keming <[email protected]>
@kemingy kemingy requested a review from VoVAllen July 24, 2024 07:43
@kemingy
use query value
60a707f 
Signed-off-by: Keming <[email protected]>
@kemingy kemingy requested a review from usamoi July 26, 2024 05:45
usamoi
usamoi previously approved these changes Jul 26, 2024
View reviewed changes
Copy link
Collaborator

@usamoi usamoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Names like inverted_file_bm25 or inverted_file_sparse may be better.

crates/inverted/src/operator.rs Outdated Show resolved Hide resolved
crates/base/src/index.rs Outdated Show resolved Hide resolved
@kemingy
fix lint
682ee45 
Signed-off-by: Keming <[email protected]>
@kemingy kemingy requested a review from usamoi July 29, 2024 08:03
usamoi
usamoi reviewed Jul 31, 2024
View reviewed changes
crates/inverted/src/operator.rs Outdated Show resolved Hide resolved
crates/inverted/src/lib.rs Outdated Show resolved Hide resolved
crates/inverted/src/lib.rs Outdated Show resolved Hide resolved
crates/inverted/src/lib.rs Outdated Show resolved Hide resolved
@usamoi
Copy link
Collaborator

usamoi commented Jul 31, 2024

InvertedSparse. Sparse is even not a noun...

@kemingy kemingy requested a review from usamoi August 2, 2024 04:01
@kemingy kemingy added this pull request to the merge queue Aug 2, 2024
Merged via the queue into tensorchord:main with commit 49373c3 Aug 2, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@usamoi usamoi usamoi approved these changes

@VoVAllen VoVAllen Awaiting requested review from VoVAllen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: flat sparse vector index using column oriented layout
2 participants
@kemingy @usamoi