Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom adaptor tutorial example #66

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tcbrindle
Copy link
Owner

No description provided.

@codecov
Copy link

codecov bot commented May 4, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (0440cdc) 97.70% compared to head (51e07ce) 97.70%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #66   +/-   ##
=======================================
  Coverage   97.70%   97.70%           
=======================================
  Files          62       62           
  Lines        2045     2045           
=======================================
  Hits         1998     1998           
  Misses         47       47           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tcbrindle
Copy link
Owner Author

@jnytra If you can, would you mind looking through this tutorial/example and letting me know if anything is unclear or doesn't make sense?

@jnytra
Copy link
Contributor

jnytra commented May 6, 2023

This is absolutely amazing. This is exactly what I needed to write a new adaptor. I don't have any comments yet, but I plan to write a new adaptor according to this tutorial, so I'll see.

@tcbrindle
Copy link
Owner Author

This is absolutely amazing. This is exactly what I needed to write a new adaptor. I don't have any comments yet, but I plan to write a new adaptor according to this tutorial, so I'll see.

@jnytra Sounds good! If you're planning to add any new adaptors or algorithms please file an issue first (I'll mark it as an enhancement and assign you to "fix" it) so that we don't end up working on the same thing :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants