Skip to content

Commit

Permalink
Add note about conventions as part of Stage 3 review
Browse files Browse the repository at this point in the history
Not every Stage 3 reviewer needs to verify the specification
conventions, but for those who have the disposition to perform that kind
of review, a reminder and pointer can be useful.
  • Loading branch information
ptomato committed Aug 26, 2022
1 parent 0e97108 commit 391aecf
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion stage-3-review.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ When reviewing a TC39 proposal, read the specification text, README and other do
- Does the proposal fit in well when combined with other JavaScript language features (both current and proposed, a.k.a. "cross-cutting concerns")? Will the interactions between features be surprising or strange?
- Does the proposal scope make sense, or would this make more sense as a larger or smaller proposal?
- Does the specification text completely cover every aspect of the proposal, or are some things unstated?
- Is the specification text logical and consistent, matching the rest of the JavaScript specification?
- Is the specification text logical and consistent, matching the rest of the JavaScript specification? (For this kind of review, it can be useful to refresh yourself on the [conventions](./spec-conventions.md).)
- Do all of the details and edge cases seem reasonably motivated?

To give your feedback to the champion group, file issues in GitHub, or make pull requests with proposed changes.
Expand Down

0 comments on commit 391aecf

Please sign in to comment.