-
-
Notifications
You must be signed in to change notification settings - Fork 945
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf(webfont): improve build performance #1316
Open
kakkokari-gtyih
wants to merge
8
commits into
tabler:main
Choose a base branch
from
kakkokari-gtyih:perf-improve-font-generation-time
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
perf(webfont): improve build performance #1316
kakkokari-gtyih
wants to merge
8
commits into
tabler:main
from
kakkokari-gtyih:perf-improve-font-generation-time
+9,322
−7,473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@kakkokari-gtyih can you resolve conflicts? |
@codecalm Conflict resolved! |
There's no conflicts so far |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request improves the usage of external tools such as FontForge and svgo and reduces massive console output.
This will greatly reduce the time required to build webfont. In my environment, this used to take 45 minutes when there's no cache. Afrer the refactoring, build time was reduced to about 15-20 minutes even without cache.
(most of diffs are from pnpm lockfile; actual changes are not that much)
Notable Changes
pnpm build:webfont --debug
(--debug arg).icons-outlined/<weight>/<variant>/new
and the folder is deleted after all optimization is complete.Minor Changes
sys
library (Close Fix build script python errors #1069)execa
to the devDependencies (Close pnpm-lock.yaml is unsupported by pnpm version specified in package.json #1311)