Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Babel (which was not really necessary), replace it by acorn if needed, close #105 #116

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

Kocal
Copy link
Member

@Kocal Kocal commented Jan 29, 2025

Babel configuration files .babel.rc and babel.config.js were not used (anymore), @babel/parser can be replaced by acorn that we already use, so we can remove Babel and remove ~120 devDependencies:

  • before:
Progress: resolved 1, reused 0, downloaded 0, added 0
Progress: resolved 11[8](https://github.com/symfony/stimulus-bridge/actions/runs/13026638540/job/36336794852?pr=115#step:6:9), reused 1, downloaded 99, added 0
Progress: resolved 284, reused 1, downloaded 243, added 0
Packages: +360
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Progress: resolved 423, reused 1, downloaded 364, added 360, done
.../[email protected]/node_modules/esbuild postinstall$ node install.js
.../node_modules/@biomejs/biome postinstall$ node scripts/postinstall.js
.../[email protected]/node_modules/esbuild postinstall: Done
.../node_modules/@biomejs/biome postinstall: Done

dependencies:
+ @hotwired/stimulus-webpack-helpers 1.0.1
+ @types/webpack-env 1.18.8
+ loader-utils 3.3.1
+ schema-utils 4.3.0

devDependencies:
+ @babel/core 7.26.7
+ @babel/parser 7.26.7
+ @babel/preset-env 7.26.7
+ @babel/preset-typescript 7.26.0
+ @babel/types 7.26.7
+ @biomejs/biome 1.[9](https://github.com/symfony/stimulus-bridge/actions/runs/13026638540/job/36336794852?pr=115#step:6:10).4
+ @hotwired/stimulus 3.2.2
+ @rollup/plugin-typescript 12.1.2
+ @symfony/mock-module 1.0.0
+ @testing-library/jest-dom 6.6.3
+ acorn 8.14.0
+ jsdom 26.0.0
+ json5 2.2.3
+ rolldown 1.0.0-beta.3
+ tslib 2.8.1
+ typescript 4.9.5 (5.7.3 is available)
+ vitest 3.0.4
+ webpack 5.97.1
+ webpack-cli 5.1.4 (6.0.1 is available)

 WARN  Issues with peer dependencies found
.
└─┬ valibot 1.0.0-beta.[12](https://github.com/symfony/stimulus-bridge/actions/runs/13026638540/job/36336794852?pr=115#step:6:13)
  └── ✕ unmet peer typescript@>=5: found 4.9.5

Done in 3.9s
  • after:
Progress: resolved 1, reused 0, downloaded 0, added 0
Progress: resolved 68, reused 1, downloaded 27, added 0
Progress: resolved 210, reused 1, downloaded 173, added 0
Packages: +241
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Progress: resolved 304, reused 1, downloaded 245, added 241, done
.../node_modules/@biomejs/biome postinstall$ node scripts/postinstall.js
.../[email protected]/node_modules/esbuild postinstall$ node install.js
.../node_modules/@biomejs/biome postinstall: Done
.../[email protected]/node_modules/esbuild postinstall: Done
dependencies:
+ @hotwired/stimulus-webpack-helpers 1.0.1
+ @types/webpack-env 1.18.8
+ loader-utils 3.3.1
+ schema-utils 4.3.0
devDependencies:
+ @biomejs/biome 1.[9](https://github.com/symfony/stimulus-bridge/actions/runs/13026994439/job/36337823223?pr=116#step:6:9).4
+ @hotwired/stimulus 3.2.2
+ @rollup/plugin-typescript 12.1.2
+ @symfony/mock-module 1.0.0
+ @testing-library/jest-dom 6.6.3
+ acorn 8.14.0
+ jsdom 26.0.0
+ json5 2.2.3
+ rolldown 1.0.0-beta.3
+ tslib 2.8.1
+ typescript 4.9.5 (5.7.3 is available)
+ vitest 3.0.4
+ webpack 5.97.1
+ webpack-cli 5.1.4 (6.0.1 is available)
 WARN  Issues with peer dependencies found
.
└─┬ valibot 1.0.0-beta.[12](https://github.com/symfony/stimulus-bridge/actions/runs/13026994439/job/36337823223?pr=116#step:6:12)
  └── ✕ unmet peer typescript@>=5: found 4.9.5
Done in 3.5s

@Kocal Kocal merged commit aa49651 into symfony:main Jan 29, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant