Update to Symfony 7.2

[javiereguiluz]

No description provided.

[javiereguiluz]

I have two questions:

@nicolas-grekas do you agree on using an empty value for the APP_SECRET env var in .env file as done in the recipe?

@stof do you know which is the best way to solve this PHPStan issue?

Error: Method App\Entity\User::getUserIdentifier() should return non-empty-string but returns string.
 ------ ----------------------------------------------------------- 
  Line   src/Entity/User.php                                        
 ------ ----------------------------------------------------------- 
  85     Method App\Entity\User::getUserIdentifier() should return  
         non-empty-string but returns string.                       
 ------ ----------------------------------------------------------- 

Thanks!

[stof]

@javiereguiluz annotating the User entity to tell phpstan that the identifier property contains a non-empty-string and not just any string

[nicolas-grekas]

A non empty kernel.secret is required for remember_me, so we cannot empty it, unless we also comment out the remember me feature in security.yaml

[javiereguiluz]

@stof I tried adding the non-empty-string but it doesn't work. Maybe it's because the property can also be null. See

demo/src/Entity/User.php

Line 53 in 22d4acf

private ?string $username = null;

@nicolas-grekas if I use an empty APP_SECRET, the app works as expected, including the "Remember Me" feature. Should I see an exception instead? What am I missing?

[stof]

@javiereguiluz aren't you seeing a deprecation at least ?

[javiereguiluz]

No. Now I also removed APP_SECRET from .env.test and I don't see a deprecation when running tests either.

[nicolas-grekas]

That's a bug, fixed by symfony/symfony#58419
If we want to have an empty APP_SECRET but still use remember me, we could configure a persistent remember strategy.

[nicolas-grekas]

If we want to have an empty APP_SECRET but still use remember me, we could configure a persistent remember strategy.

Actually that's not enough because ESI/fragments need the secret also.

[javiereguiluz]

Closing in favor of #1532.