Use Security::logout() instead of redirecting to the logout url
#1467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GromNaN
commented
Dec 4, 2023
GromNaN
commented
Dec 4, 2023
chalasr
reviewed
Dec 4, 2023
chalasr
approved these changes
Dec 6, 2023
javiereguiluz
force-pushed
the
security-logout
branch
from
5081b49 to
d056c3b
Compare
|
Jérôme, thanks a lot for this. I love the simplification introduced here 🙌 Thanks also to Robin for originally proposing this idea and for reviewing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposition from @chalasr: symfony/symfony#52833 (comment)
The logout URL generator should be used to create links with CSRF protection. In this case, the action is already secured by the form, the redirection is not necessary.