-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a "driving mode" to the REPL #819
Conversation
Things to improve:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @kostmo, it looks great and I will try it out soon! 👍
AFAIK we planned to add event handlers to the language that would be more general. Then you could use keys for grabbing etc.
But I like how your approach shows the commands, this system looks very user friendly and we could still do both. 🙂
I love the idea of driving robots around, and I tried this out and it works well. It is a little annoying trying to use it in a Creative game though, because the base always looks like In general, I do want to keep this game focused on programming; the relevant design principle is that instead of adding complex built-in features, we should strive instead to provide language constructs that allow players to program the cool features themselves. For example, see #102 for a previously discussed feature which would allow players to program their own driving mode. See also #558 for another discussion of this design principle. However, I am not against including this PR, especially if it is limited to creative mode. In fact I guess there could be something fun about seeing a feature like driving mode that's only available in cheat/creative mode, then much later realizing that you can actually program it yourself in classic mode! There are some things I like about this that make me think of improvements to #102, or more general features we could provide in the spirit of the design principle I mentioned above. This is just me brainstorming and should probably eventually be moved into new issues etc.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried it and it's great! 👍 I imagine it will at least make testing challenges easier. 🙂
I generally agree with @byorgey's comments here, but I think we can fix the mentioned issues separately. Meanwhile, this adds a lot of value to the --cheat
mode. 😁
Feel free to merge @kostmo unless you want to improve anything still.
Btw. I do not think We used to have the base orientation map with normal characters for absolute directions. The trick was that the base was facing down by default which sometimes made other robots look like the base. We can now customize this through scenarios or allow players to set it themselves. 🤷 But let's not do that here, we should aspire to have small commits. 😄 |
Related: #683 |
Ctrl+d in the REPL will toggle into "driving mode". In this mode, the arrow keys simply submit predefined commands to the REPL:
move;
turn back;
turn left;
turn right;
This yields a pretty natural driving experience: