Tooling fixes #108
Open
Tooling fixes #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Poetry was removed as the standard way to manage the package and deps in surrealdb#76. The resulting pyproject.toml was missing a number of configs for other tools. This commit: - adds the tooling info back to pyproject - adds .editorconfig file back - removes the poetry.lock file - updates typing-extensions name in deps - adds the missing tooling packages to dev_requirements - adds mise tooling files to gitignore
This was a merge diff that was left in and resolved. I also removed `poetry run` from the start of commands.
The github actions still referenced some poetry operations. I'm not sure that the `.venv` related parts are still useful but I will leave for now as they should not cause a problem.
|
stability should probably also run |
gaby
reviewed
Oct 3, 2024
|
|
||
| - id: Black | ||
| if: always() | ||
| run: poetry run black python_package/surrealdb/ --check --verbose --diff --color | ||
| run: black surrealdb/ --check --verbose --diff --color |
There was a problem hiding this comment.
This should be ruff format, no one uses black anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for submitting this pull request! We appreciate you spending the time to work on these changes.
What is the motivation?
It looks like there was a lot mangled during the effort to remove tokio and change the folder layout. I first noticed a merge conflict that got merged in but it send me down a rabbit hole with
poetrybeing removed.Type of Change
What does this change do?
It's primarily clean up of poetry items and correction of the stability action
What is your testing strategy?
I didn't change any actual code. I tested running ruff, mypy, and black from the cli and pip installed to verify requirements files.
Is this related to any issues?
There is not
Have you read the Contributing Guidelines?