fix: relock before cz bump #277
Merged
+10
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sinopeus
reviewed
Feb 18, 2025
sinopeus
reviewed
Feb 18, 2025
Co-authored-by: Xavier Goás Aguililla <[email protected]>
sinopeus
reviewed
Feb 18, 2025
Providing the --upgrade-package flag guarantees we won't incur a package cache miss, as the package metadata is in the project directory. Cache misses can occur in case the cache is not populated yet (after creating a fresh dev container).
I noticed that the UV cache doesn't get populated even after `uv sync` has been run in `postCreateCommand`. This explicitly sets the cache directory container-wide.
The node devcontainer feature is not needed in templated projects, and can therefore be removed.
lsorber
commented
Feb 19, 2025
sinopeus
force-pushed
the
ls-cz-lock
branch
2 times, most recently
from
bbeec93 to
1b7fc05
Compare
vanolucas
added a commit
to vanolucas/substrate
that referenced
this pull request
Feb 21, 2025
* fix(api): remove unnecessary default type argument (superlinear-ai#280) * fix: relock before cz bump (superlinear-ai#277) --------- Co-authored-by: Laurent Sorber <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After bumping the version with
cz bump, uv's lock file is out of sync withpyproject.toml. Until Commitizen adds support for uv, this PR addsuv lock --offlineas a pre bump hook (which runs after updating the version but before comitting and tagging) to synchronizeuv.lockandpyproject.toml.