Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix alpha encoding when using grid workaround #355

Closed
wants to merge 2 commits into from

Conversation

itaibenari
Copy link

when using the grid workaround the alpha auxl item refers to the image before it was wrapped in a grid (image_id) and causes alpha to be lost. so I changed the order and build the alpha layer after the main image.

additionally, for small images (64px), there's an assertion that breaks at heif_encoder_x265.cc:769, hence changed the alpha layer to be monochrome and only use Y.

@farindk
Copy link
Contributor

farindk commented Nov 2, 2020

@itaibenari I think your first patch 8e930c2 is fine (if the alpha is encoded as monochrome and hence can have odd size). The second patch (5866f1a) is problematic because it appears to disable the whole 'clap' processing. This would break any correct codec just to match the error is macOS.

Do we have any example case why we need to modify the 'clap' processing?

@farindk
Copy link
Contributor

farindk commented Nov 18, 2024

Seems to be obsolet now.

@farindk farindk closed this Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants