-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies - Test-Frame, Log4j, Slf4j, helm-client #67
Conversation
Signed-off-by: Lukas Kral <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, is the operator / JOSDK using SLF4J2? Because I'm not sure it can be updated from 1 to 2 just like that.
So based on this: https://github.com/operator-framework/java-operator-sdk/blob/main/pom.xml#L168 no. |
But I will try to use the new version just in STs, I think that should be possible. |
Signed-off-by: Lukas Kral <[email protected]>
@scholzj I changed the SLF4J to SLF4J2 just in the STs, so it should not break anything. But I will anyway build the image and verify that I didn't break anything with this change. |
So I built the image and it seems that everything works fine:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks
Signed-off-by: Lukas Kral <[email protected]>
This PR updates few dependencies - I wanted to update the
test-frame
, in order to implement the LogCollector, but during that, I had to update also the Log4j and Slf4j deps. Finally, the helm-client dependency has a new version as well, so I updated it all together.