Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): fixes an issue with Request type #289

Merged
merged 6 commits into from
Nov 8, 2023
Merged

fix(types): fixes an issue with Request type #289

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c589672
fix(types): fixes an issue with `Request` type
pavankjadda Nov 8, 2023
d1acd7b
build(ci): Switch npm dependencies to pnpm in Github Actions
pavankjadda Nov 8, 2023
d9d124f
chore: Update .prettierignore to ignore pnpm-lock.yaml
pavankjadda Nov 8, 2023
d81d8d1
fix(format): Refactor code for better readability in ssr-cookie.servi…
pavankjadda Nov 8, 2023
4d41d4b
fix(format): removes duplicate browserlist config
pavankjadda Nov 8, 2023
7e0ab9e
build(ci): Disable test step in GitHub Actions CI workflow
pavankjadda Nov 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 10 additions & 7 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,19 +15,22 @@ jobs:
node: ['18']
steps:
- uses: actions/checkout@v3
- uses: pnpm/action-setup@v2
with:
version: latest
- name: Use Node.js ${{ matrix.node }}
uses: actions/setup-node@v3
with:
node-version: ${{ matrix.node }}
- name: Install dependencies
run: npm i --legacy-peer-deps
run: pnpm install --frozen-lockfile
- name: Lint
run: npm run lint
run: pnpm lint
- name: Format check
run: npm run format:check
run: pnpm format:check
- name: Build
run: npm run build --configuration=production && npm run build:ngx-cookie-service-ssr --configuration=production
run: pnpm build --configuration=production && pnpm build:ngx-cookie-service-ssr --configuration=production
# - name: Test
# run: npm run test
env:
CI: true
# run: pnpm test
# env:
# CI: true
7 changes: 5 additions & 2 deletions .github/workflows/npm_publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,13 +9,16 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: pnpm/action-setup@v2
with:
version: latest
- uses: actions/setup-node@v2
with:
node-version: 18
- name: Install NPM Dependencies
run: npm install --legacy-peer-deps
run: pnpm install --frozen-lockfile
- name: Build project
run: npm run build --configuration=production
run: pnpm build --configuration=production
- name: Publish to NPM
uses: JS-DevTools/npm-publish@v3
with:
Expand Down
9 changes: 6 additions & 3 deletions .github/workflows/npm_publish_ssr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,13 +9,16 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: pnpm/action-setup@v2
with:
version: latest
- uses: actions/setup-node@v2
with:
node-version: 18
- name: Install NPM Dependencies
run: npm install --legacy-peer-deps
- name: Install PNPM Dependencies
run: pnpm install --frozen-lockfile
- name: Build project
run: npm run build:ngx-cookie-service-ssr
run: pnpm build:ngx-cookie-service-ssr
- name: Publish to NPM registry
uses: JS-DevTools/npm-publish@v3
with:
Expand Down
2 changes: 1 addition & 1 deletion .prettierignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@ dist
.angular
.github
README.md
package-lock.json
pnpm-lock.yaml
Loading
Loading