feat(core): adds angular 17.0.0-rc.3 #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sr-cookie.service.ts` file. This is part of the upgrading process to Angular 17.0.0-rc.3 which required changes in import paths due to the restructuring of libraries and packages.
# Conflicts: # .github/workflows/ci.yml # .github/workflows/npm_publish.yml # .github/workflows/npm_publish_ssr.yml # package.json # projects/ngx-cookie-service-ssr/package.json # projects/ngx-cookie-service/package.json
# Conflicts: # pnpm-lock.yaml
The existing commands for 'format:write' and 'format:check' in the script section of package.json were incorrect as they did not properly call the format command. This commit changes 'npm format' to 'npm run format' to properly execute the commands.
The existing commands for 'format:write' and 'format:check' in the script section of package.json were incorrect as they did not properly call the format command. This commit changes 'npm format' to 'npm run format' to properly execute the commands.
The package-lock.json file has been removed from the project. This may result in different dependency versions being installed on different environments, potentially leading to inconsistent behavior across different setups. Future commits should avoid modifying the package-lock.json file unless necessary.
Updated the GitHub workflows to use PNPM for package management instead of NPM. This change affects both the npm_publish_ssr.yml and ci.yml workflows. Additionally, a pnpm-lock.yaml file was added to the project.
The commit upgraded all Angular related dependencies from 16.2.1 to 17.0.0-rc, and other packages like rxjs, tslib, and zone.js to their latest versions as per the pnpm-lock.yaml file. This will provide the latest features and bug fixes available in Angular and other dependencies. Furthermore, the '@nguniversal/express-engine' has been replaced by '@angular/ssr'.
The browserslist was moved out of the package.json and into a new .browserslistrc file. This cleanup was necessary to follow best practices and helps in maintaining consistency across projects. The .browserslistrc file is easier to maintain and more configurable.
# Conflicts: # package.json # pnpm-lock.yaml # projects/ngx-cookie-service-ssr/package.json # projects/ngx-cookie-service/package.json
|
Hello 👋 @pavankjadda |
|
SonarCloud Quality Gate failed.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.