[pull] master from styleguidist:master #237
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
Codecov Report
@@ Coverage Diff @@
## master #237 +/- ##
=======================================
Coverage 97.34% 97.34%
=======================================
Files 155 155
Lines 1809 1809
Branches 501 501
=======================================
Hits 1761 1761
Misses 47 47
Partials 1 1 Continue to review full report at Codecov.
|
Remove is-directory that is no longer maintained and replace it with direct calls of the fs module. It does exactly the same thing as is-directory with a bonus of having types built-in.
Bumps [url-parse](https://github.com/unshiftio/url-parse) from 1.4.7 to 1.5.3. - [Release notes](https://github.com/unshiftio/url-parse/releases) - [Commits](unshiftio/url-parse@1.4.7...1.5.3) --- updated-dependencies: - dependency-name: url-parse dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Upgrade react-dev-utils to latest version v12 (supports Webpack 5) * Fix Webpack example for local testing * Upgrade webpack related dependencies for maintenance: webpack, webpack-cli, and webpack-dev-server * Remove unnecessary Webpack configuration around Hot Module Replacement. webpack-dev-server should automatically inject HMR related configurations already Closes #1703 Closes #1864 Closes #1740 Closes #1822 Closes #1786
Bumps [prismjs](https://github.com/PrismJS/prism) from 1.16.0 to 1.26.0. - [Release notes](https://github.com/PrismJS/prism/releases) - [Changelog](https://github.com/PrismJS/prism/blob/master/CHANGELOG.md) - [Commits](PrismJS/prism@v1.16.0...v1.26.0) --- updated-dependencies: - dependency-name: prismjs dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.10.0 to 1.14.7. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](follow-redirects/follow-redirects@v1.10.0...v1.14.7) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.9.0 to 1.14.7. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](follow-redirects/follow-redirects@v1.9.0...v1.14.7) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.9.0 to 1.14.7. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](follow-redirects/follow-redirects@v1.9.0...v1.14.7) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.9.0 to 1.14.7. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](follow-redirects/follow-redirects@v1.9.0...v1.14.7) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.9.0 to 1.14.7. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](follow-redirects/follow-redirects@v1.9.0...v1.14.7) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.9.0 to 1.14.7. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](follow-redirects/follow-redirects@v1.9.0...v1.14.7) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [browserslist](https://github.com/browserslist/browserslist) from 4.14.5 to 4.19.1. - [Release notes](https://github.com/browserslist/browserslist/releases) - [Changelog](https://github.com/browserslist/browserslist/blob/main/CHANGELOG.md) - [Commits](browserslist/browserslist@4.14.5...4.19.1) --- updated-dependencies: - dependency-name: browserslist dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [ua-parser-js](https://github.com/faisalman/ua-parser-js) from 0.7.17 to 0.7.31. - [Release notes](https://github.com/faisalman/ua-parser-js/releases) - [Commits](faisalman/ua-parser-js@0.7.17...0.7.31) --- updated-dependencies: - dependency-name: ua-parser-js dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This is a start for upgrading to webpack 5 and webpack-dev-server ^4. With these changes, the basic examples are working ( incl. hot module reloading ). But there are more todo's left * update dev-server config * make StyleguidistOptionsPlugin.ts work with webpack 5 and fix test * fix make-webpack-config.spec.ts tests * upgrade other webpack loader dependencies to latests versions (optional?) * fix type errors * fix deprecation warnings Fixes #1932 BREAKING CHANGE: Webpack 4 is no longer supported.
* fix: ensure devserver client options are configurable When a custom `webpackConfig.devServer.client` option is set, they are currently being overridden by the `baseConfig.client` field. Ensure that field is extendible by consumers while also ensuring the base config values stay fixed. #2033 * fix: ensure all devServer options are overridable; add tests
* upgrade react core depedencies to React 17 * Upgrade react-simple-code-editor and remove enzyme react 16 adapter * replace enzyme adapter react * Fix: fix failing Editor test * Chore: update dependencies in examples/basic BREAKING CHANGE: React 16 no longer supported
* chore: Migrated enzyme tests to react-testing-render or @testing-library/react. This is required for an upgrade to React 18, which enzyme does not support. I've tried to keep the impact on the tests as small as possible. Shallow snapshot tests use react-test-renderer/shallow.createRenderer Deep snapshot tests use react-test-renderer.create Interaction tests use @testing-library/react.render In snapshots 'class' changed to 'className'. The 'key' property is no longer emitted. Injected HTML is formatted differently (quoted an no newlines). Some tests navigated into the render output to pick out a smaller piece to snapshot. That was too difficult to replicate. There is a problem with the deabsdeep/serializer. It breaks serialization of React Elements, because the map 'loses' the $$typeof marker used by jest's native React serializer. I've copied the serializer code into this project and fixed the problem. In the future we could look at using this serializer selectively for only tests that needs it. deabsdeep library is still used in places, just not the serializer. * chore: remove enzyme config from jest setup * chore: remove enzyme dependencies * chore: add temp istanbul / codecov ignore related: 212cf66 * fix: fix some name conflict eslint warnings Co-authored-by: Frits van Campen <[email protected]> Co-authored-by: Thomas Roest <[email protected]>
Upgrade to React 18 * replace ReactDOM.render with createRoot in index.ts * fix new TS errors after upgrading @types * replace ReactDOM.render in Preview.tsx * replace ReactDOM.unmountComponentAtNode with root.unmount() * remove ReactDOM import * upgrade react testing library * replace deprecated React.SFC type with React.FC DefinitelyTyped/DefinitelyTyped#30364 * Fix TS errors in propTypes.children propTypes.node results in TS errors. There doesn't seem to be a good alternative ( other than making the children propTypes more strict, which could result more errors) Instead use something less restrictive (propTypes.any) for children and components. * fix TS errors, extract props interfaces with children * fix TS errors, add context types * TS fix * Fix React unmount error Unmount asynchronously with setTimout https://stackoverflow.com/questions/73459382/react-18-async-way-to-unmount-root error message: Warning: Attempted to synchronously unmount a root while React was already rendering. React cannot finish unmounting the root until the current render has completed, which may lead to a race condition. * make wrapper unmount test async --------- Co-authored-by: Thomas Roest <[email protected]>
Co-authored-by: Thomas Roest <[email protected]>
310b08a Co-authored-by: Thomas Roest <[email protected]>
Co-authored-by: Thomas Roest <[email protected]>
fix: fix preview not visible after error fixes #2154 --------- Co-authored-by: Thomas Roest <[email protected]>
* fix: update node version for semantic release --------- Co-authored-by: Thomas Roest <[email protected]>
Co-authored-by: Thomas Roest <[email protected]>
When having a single line statement with an import statement everything works as expected.
```jsx
import * as React from "react";
<ReactComponent />;
```
However if you remove the import statement, a semicolon `;` appears in the output. We no longer need the explicit import statements as this can be configured globally, and we have an eslint rule requiring us to close every js statement with a semicolon.
```jsx
<ReactComponent />;
```
This happens because of the fix/changes done in this issue: #842, which causes every statement starting with JSX to be wrapped in a Fragment. This will cause the semicolon to be added inside the Fragment, and cause it to be rendered.
This change causes the examples to only be wrapped in a Fragment if multiple jsx statements are returned on root level of the example by checking for the error before wrapping.
Co-authored-by: Thomas Roest <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )