fix: consider the tool role when being in open interpreter #829
+104
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It uses a new message role tool, that contains some context for using internal tools and the data it provides. So we need to consider it when parsing messages, or when inserting context messages Closes: #820
yrobla
requested review from
lukehinds,
jhrozek,
JAORMX and
aponcedeleonch
and removed request for
lukehinds
jhrozek
reviewed
Jan 29, 2025
jhrozek
reviewed
Jan 30, 2025
| accepted_roles = ["user", "assistant"] | ||
| if base_tool == "open interpreter": | ||
| # open interpreter also uses the role "tool" | ||
| accepted_roles.append("tool") |
There was a problem hiding this comment.
sorry to be difficult about this review.
Would it break anything if we accepted the tools either way, meaning for all clients?
What do we miss if we don't process the tool messages here?
There was a problem hiding this comment.
well i was not aware if any other client using tools but wanted to be conservative about it, so that's why i filter by the client. Do you prefer that i open that and we do not filter?
jhrozek
reviewed
Jan 30, 2025
src/codegate/pipeline/base.py
Outdated
| user_messages.append(content_str) | ||
| block_start_index = i | ||
|
|
||
| # Specifically for Aider, when "Ok." block is found, stop | ||
| if content_str == "Ok." and messages[i]["role"] == "assistant": | ||
| if base_tool == "aider" and content_str == "Ok." and messages[i]["role"] == "assistant": |
There was a problem hiding this comment.
how do we detect aider? I looked into get_tool_name_from_messages and I don't see aider returned from there
There was a problem hiding this comment.
i actually removed that, it is outdated, i removed the check for aider
jhrozek
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It uses a new message role tool, that contains some context for using internal tools and the data it provides. So we need to consider it when parsing messages, or when inserting context messages
Closes: #820