Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use react-query for fetching alerts #95

Merged
merged 6 commits into from
Jan 16, 2025

Conversation

kantord
Copy link
Member

@kantord kantord commented Jan 16, 2025

no visual change. just refactors the data fetching for alerts so that it is using react-query. Zustand is still used to handle the search state, no major refactor there

@kantord kantord force-pushed the use-react-query-for-fetching-alerts branch from 052e2ac to dfe1f4f Compare January 16, 2025 15:55
@kantord kantord changed the title Use react query for fetching alerts refactor: use react-query for fetching alerts Jan 16, 2025
@kantord kantord marked this pull request as ready for review January 16, 2025 15:55
@kantord kantord marked this pull request as draft January 16, 2025 15:56
@coveralls
Copy link
Collaborator

coveralls commented Jan 16, 2025

Pull Request Test Coverage Report for Build 12812794630

Details

  • 37 of 37 (100.0%) changed or added relevant lines in 3 files are covered.
  • 7 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-1.4%) to 67.279%

Files with Coverage Reduction New Missed Lines %
src/mocks/msw/handlers.ts 1 75.0%
src/api/generated/sdk.gen.ts 1 53.85%
src/hooks/usePromptsData.ts 5 25.0%
Totals Coverage Status
Change from base Build 12811319547: -1.4%
Covered Lines: 385
Relevant Lines: 492

💛 - Coveralls

@kantord kantord marked this pull request as ready for review January 16, 2025 16:03
@kantord kantord enabled auto-merge (squash) January 16, 2025 16:03
@kantord kantord requested review from alex-mcgovern and peppescg and removed request for alex-mcgovern January 16, 2025 16:04
Copy link
Collaborator

@alex-mcgovern alex-mcgovern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job

@kantord kantord merged commit b77f480 into main Jan 16, 2025
8 of 9 checks passed
@kantord kantord deleted the use-react-query-for-fetching-alerts branch January 16, 2025 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants