Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use @stacklok/ui-kit #80

Merged
merged 20 commits into from
Jan 16, 2025
Merged

feat: use @stacklok/ui-kit #80

merged 20 commits into from
Jan 16, 2025

Conversation

alex-mcgovern
Copy link
Collaborator

@alex-mcgovern alex-mcgovern commented Jan 15, 2025

This PR rewrites the UI to use the internal @stacklok/ui-kit component library — mainly to unlock a speed boost and avoid solving problems we have already solved (like dark mode).

@alex-mcgovern alex-mcgovern self-assigned this Jan 15, 2025
@alex-mcgovern alex-mcgovern changed the title feat: UIKit (POC & WIP) feat: use @stacklok/ui-kit Jan 15, 2025
@coveralls
Copy link
Collaborator

coveralls commented Jan 15, 2025

Pull Request Test Coverage Report for Build 12805902815

Details

  • 20 of 26 (76.92%) changed or added relevant lines in 8 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.6%) to 68.977%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/api/generated/sdk.gen.ts 4 5 80.0%
src/features/dashboard/components/card-codegate-status.tsx 2 3 66.67%
src/components/Certificates.tsx 3 5 60.0%
src/components/ui/sidebar.tsx 0 2 0.0%
Files with Coverage Reduction New Missed Lines %
src/components/ui/sidebar.tsx 1 58.91%
Totals Coverage Status
Change from base Build 12793870984: -0.6%
Covered Lines: 399
Relevant Lines: 501

💛 - Coveralls

@alex-mcgovern alex-mcgovern marked this pull request as ready for review January 15, 2025 18:07
@peppescg
Copy link
Collaborator

The copy to clipboard component is a very raw component, we need to replace it IMO, do we have it in ui-kit 🤔 ?

Anyways the issue here is the color, we need to replace it for dark theme

Screenshot 2025-01-16 at 10 00 57

@alex-mcgovern alex-mcgovern merged commit 48e7103 into main Jan 16, 2025
7 of 8 checks passed
@alex-mcgovern alex-mcgovern deleted the feat/ui-kit branch January 16, 2025 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants