Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AngularV19 #46

Merged
merged 3 commits into from
Nov 21, 2024
Merged

AngularV19 #46

merged 3 commits into from
Nov 21, 2024

Conversation

JeevanMahesha
Copy link
Contributor

No description provided.

@JeevanMahesha
Copy link
Contributor Author

@JeanMeche I have updated it for V19 can you please review.

@JeevanMahesha
Copy link
Contributor Author

@Nemikolh / @d3lm can you please review this PR

angular/package.json Outdated Show resolved Hide resolved
Copy link
Contributor

@d3lm d3lm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me but in terms of the actual changes I'd defer to @JeanMeche to check if this is all correct.

Copy link
Contributor

@JeanMeche JeanMeche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@d3lm
Copy link
Contributor

d3lm commented Nov 21, 2024

@JeevanMahesha Seems like prettier check fails.

@JeevanMahesha
Copy link
Contributor Author

@d3lm fixed prettier check.

@d3lm d3lm merged commit 3d54fa1 into stackblitz:main Nov 21, 2024
2 checks passed
@d3lm
Copy link
Contributor

d3lm commented Nov 21, 2024

Thanks @JeevanMahesha 🙏

@JeevanMahesha JeevanMahesha deleted the angularV19 branch November 22, 2024 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants