Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Note for more context #152

Closed
wants to merge 1 commit into from
Closed

Conversation

haroonalbar
Copy link
Contributor

Additional note on finding duplicate in array on pros and cons of using marking technique.

@spring1843
Copy link
Owner

Thanks for opening this PR. Although your note is correct:

  • We don't add such comments to the code
  • This technique has educational value, what you are describing could be a new problem. If you are interested please feel free to add that as a new problem in a new PR. It can be beneficial for readers to compare the two.

For these two reasons I'm gonna close this PR.

@spring1843 spring1843 closed this Nov 26, 2024
@haroonalbar
Copy link
Contributor Author

Alright

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants