Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimized _partition_tasks function by reducing iterations over task_… #3261

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Optimized _partition_tasks function by reducing iterations over task_… #3261

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a193a4b
Optimized _partition_tasks function by reducing iterations over task_…
arjun-234 Nov 16, 2023
50ccf46
Merge branch 'spotify:master' into master
arjun-234 Dec 21, 2023
a1ff796
Merge branch 'master' into master
arjun-234 Mar 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
57 changes: 39 additions & 18 deletions luigi/execution_summary.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,24 +94,45 @@ def _partition_tasks(worker):
Still_pending_not_ext is only used to get upstream_failure, upstream_missing_dependency and run_by_other_worker
"""
task_history = worker._add_task_history
pending_tasks = {task for (task, status, ext) in task_history if status == 'PENDING'}
set_tasks = {}
set_tasks["completed"] = {task for (task, status, ext) in task_history if status == 'DONE' and task in pending_tasks}
set_tasks["already_done"] = {task for (task, status, ext) in task_history
if status == 'DONE' and task not in pending_tasks and task not in set_tasks["completed"]}
set_tasks["ever_failed"] = {task for (task, status, ext) in task_history if status == 'FAILED'}
set_tasks["failed"] = set_tasks["ever_failed"] - set_tasks["completed"]
set_tasks["scheduling_error"] = {task for (task, status, ext) in task_history if status == 'UNKNOWN'}
set_tasks["still_pending_ext"] = {task for (task, status, ext) in task_history
if status == 'PENDING' and task not in set_tasks["ever_failed"] and task not in set_tasks["completed"] and not ext}
set_tasks["still_pending_not_ext"] = {task for (task, status, ext) in task_history
if status == 'PENDING' and task not in set_tasks["ever_failed"] and task not in set_tasks["completed"] and ext}
set_tasks["run_by_other_worker"] = set()
set_tasks["upstream_failure"] = set()
set_tasks["upstream_missing_dependency"] = set()
set_tasks["upstream_run_by_other_worker"] = set()
set_tasks["upstream_scheduling_error"] = set()
set_tasks["not_run"] = set()

set_tasks = {
"completed": set(),
"already_done": set(),
"ever_failed": set(),
"failed": set(),
"scheduling_error": set(),
"still_pending_ext": set(),
"still_pending_not_ext": set(),
"run_by_other_worker": set(),
"upstream_failure": set(),
"upstream_missing_dependency": set(),
"upstream_run_by_other_worker": set(),
"upstream_scheduling_error": set(),
"not_run": set()
}

pending_tasks = set()

for task, status, ext in task_history:
if status == 'PENDING':
pending_tasks.add(task)
if task not in set_tasks["ever_failed"] and task not in set_tasks["completed"]:
if ext:
set_tasks["still_pending_not_ext"].add(task)
else:
set_tasks["still_pending_ext"].add(task)
elif status == 'DONE':
if task in pending_tasks:
set_tasks["completed"].add(task)
elif task not in set_tasks["completed"]:
set_tasks["already_done"].add(task)
elif status == 'FAILED':
set_tasks["ever_failed"].add(task)
if task not in set_tasks["completed"]:
set_tasks["failed"].add(task)
elif status == 'UNKNOWN':
set_tasks["scheduling_error"].add(task)

return set_tasks


Expand Down
Loading