Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add OpenTelemetry Support #198

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Conversation

Abhi347
Copy link
Member

@Abhi347 Abhi347 commented Sep 17, 2024

feat: Add OpenTelemetry Support
feat: Add Support for Tracing Propagation Headers

Things to consider:

  • The current PR is going to be a breaking change since the OpenCensus java files have new package. We need to see if we want this or not.

Copy link

codecov bot commented Sep 17, 2024

Codecov Report

Attention: Patch coverage is 74.79224% with 91 lines in your changes missing coverage. Please review.

Project coverage is 76.28%. Comparing base (db129cf) to head (5b26395).

Files with missing lines Patch % Lines
...va/com/spotify/github/v3/clients/GitHubClient.java 74.91% 63 Missing and 7 partials ⚠️
...hub/tracing/opentelemetry/OpenTelemetryTracer.java 66.66% 9 Missing and 1 partial ⚠️
...fy/github/tracing/opencensus/OpenCensusTracer.java 42.85% 3 Missing and 1 partial ⚠️
...in/java/com/spotify/github/tracing/BaseTracer.java 75.00% 3 Missing ⚠️
...n/java/com/spotify/github/tracing/TraceHelper.java 0.00% 2 Missing ⚠️
...java/com/spotify/github/v3/clients/NoopTracer.java 86.66% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #198      +/-   ##
============================================
- Coverage     77.21%   76.28%   -0.94%     
- Complexity      337      350      +13     
============================================
  Files            47       51       +4     
  Lines          1115     1189      +74     
  Branches         44       49       +5     
============================================
+ Hits            861      907      +46     
- Misses          225      251      +26     
- Partials         29       31       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Abhi347 Abhi347 force-pushed the feat/add-ot-support branch 2 times, most recently from cfd6d53 to d5b90e3 Compare September 17, 2024 15:36
feat: Add OpenTelemetry Support
feat: Add Support for Tracing Propagation Headers
@Abhi347 Abhi347 force-pushed the feat/add-ot-support branch from d5b90e3 to 92c9da5 Compare September 23, 2024 09:00
@Abhi347 Abhi347 marked this pull request as ready for review January 29, 2025 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant