fix: add keepalive to manually defined flag resolver channel #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -309,7 +309,10 @@ public Builder(@Nonnull String clientSecret) { | |||
|
|
|||
| public Builder flagResolverManagedChannel(String host, int port) { | |||
| this.flagResolverManagedChannel = | |||
| ManagedChannelBuilder.forAddress(host, port).usePlaintext().build(); | |||
| ManagedChannelBuilder.forAddress(host, port) | |||
| .keepAliveTime(Duration.ofMinutes(5).getSeconds(), TimeUnit.SECONDS) | |||
There was a problem hiding this comment.
I read up a bit on this, and maybe this setting won't hurt, but I don't think it's helping much either. It's the idle timeout that controls how long an inactive connection is kept open, and it defaults to infinity. There might still be an idea to send periodic keep alive to monitor the health of the connection, in our use-case I don't think it's necessary though. We would also need to set permit keep alive without calls as otherwise the keep alive is only active within a long streaming call, which seems to be it's primary purpose.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the keep-alive functionality to the manually defined flag resolver grpc channel.