refactor: add constructor with null telemetry

spotify · Nov 14, 2024 · fadb798 · fadb798
1 parent a0ac42d
commit fadb798
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/openfeature-provider/src/test/java/com/spotify/confidence/FlagResolverContextTest.java b/openfeature-provider/src/test/java/com/spotify/confidence/FlagResolverContextTest.java
@@ -19,7 +19,7 @@ public class FlagResolverContextTest {
   void beforeEach() {
     final FakeEventSenderEngine fakeEventSender = new FakeEventSenderEngine(new FakeClock());
     this.fakeFlagResolver = new FakeFlagResolver();
-    final FlagResolverClientImpl flagResolver = new FlagResolverClientImpl(fakeFlagResolver, null);
+    final FlagResolverClientImpl flagResolver = new FlagResolverClientImpl(fakeFlagResolver);
     this.confidence = Confidence.create(fakeEventSender, flagResolver);
     final FeatureProvider featureProvider = new ConfidenceFeatureProvider(confidence);
 

diff --git a/sdk-java/src/main/java/com/spotify/confidence/FlagResolverClientImpl.java b/sdk-java/src/main/java/com/spotify/confidence/FlagResolverClientImpl.java
@@ -19,6 +19,10 @@ public FlagResolverClientImpl(FlagResolver grpcFlagResolver, @Nullable Telemetry
     this.telemetry = telemetry;
   }
 
+  public FlagResolverClientImpl(FlagResolver grpcFlagResolver) {
+    this(grpcFlagResolver, null);
+  }
+
   public CompletableFuture<ResolveFlagsResponse> resolveFlags(
       String flagName, ConfidenceValue.Struct context, Boolean isProvider) {
     final Instant start = Instant.now();

diff --git a/sdk-java/src/test/java/com/spotify/confidence/ConfidenceIntegrationTest.java b/sdk-java/src/test/java/com/spotify/confidence/ConfidenceIntegrationTest.java
@@ -479,7 +479,7 @@ public void resolveDoesNotContainHeaderWithTelemetryDataWhenDisabled() {
         new FakeTelemetryClientInterceptor(null);
     final FlagResolverClientImpl flagResolver =
         new FlagResolverClientImpl(
-            new GrpcFlagResolver("fake-secret", channel, nullTelemetryInterceptor), null);
+            new GrpcFlagResolver("fake-secret", channel, nullTelemetryInterceptor));
     confidence = Confidence.create(fakeEventSender, flagResolver);
 
     mockSampleResponse();