PAX Extract file fix Pull#2 #19
Conversation
fixing directory size to match zero on TAR archives FileInfo
FileInfo code display fix
When adding a file which size is being changed during archiving, the archive would become corrupt because the size in the header is different than the size of the actual data written. So an additional check should be done and if the sizes are different, the header should be updated. A quick test would be to create a loop where you write 1 byte to a test.txt file and then trying to add that file to the archive and extracting the archive.
When adding a file which size is being changed during archiving, the archive would become corrupt because the size in the header is different than the size of the actual data written. So an additional check should be done and if the sizes are different, the header should be updated. A quick test would be to create a loop where you write 1 byte to a test.txt file and then trying to add that file to the archive and extracting the archive.
| @@ -186,7 +186,38 @@ public function test_dogfood() | |||
| unlink($archive); | |||
| } | |||
| } | |||
|
|
|||
| /** | |||
There was a problem hiding this comment.
indentation seem wrong again. please make sure you use 4 spaces for indentation. not tabs!
| $filename = trim($this->readbytes(ceil($return['size'] / 512) * 512)); | ||
| // next block is the real header | ||
| $block = $this->readbytes(512); | ||
| $return = $this->parseHeader($block); |
There was a problem hiding this comment.
I don't understand. You are not using the data read from x header. $filename is never used. You basically just read and ignore the x header.
Since your tests work, I assume the original header already contains the proper UTF-8 filename? Would a very long UTF-8 filename have an x and an L header?
|
Looking at the IBM document you provided in #18 an So for implementing it correctly, the The header may also contain a Ideally we should also create such a header when adding UTF-8 filenames. |
No description provided.