Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): workaround for @speckle/viewer not found error when running dev server #892

Merged
merged 1 commit into from
Aug 5, 2022

Conversation

fabis94
Copy link
Contributor

@fabis94 fabis94 commented Aug 5, 2022

workaround for the following issue: TypeStrong/fork-ts-checker-webpack-plugin#771

essentially we no longer clean the dist folder between @speckle/viewer rebuilds, so that fork-ts-checker-webpack-plugin doesn't break and think the types no longer exist

this does make the viewer package build process a few seconds longer, but there's no other option

@codecov
Copy link

codecov bot commented Aug 5, 2022

Codecov Report

Merging #892 (d5034cb) into main (a0fe0b8) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #892   +/-   ##
=======================================
  Coverage   90.54%   90.54%           
=======================================
  Files          87       87           
  Lines        3374     3374           
  Branches        5        5           
=======================================
  Hits         3055     3055           
  Misses        319      319           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@fabis94 fabis94 merged commit 0cc69fe into main Aug 5, 2022
@fabis94 fabis94 deleted the frontend-viewer-missing-workaround1 branch August 24, 2022 13:34
@fabis94 fabis94 restored the frontend-viewer-missing-workaround1 branch August 24, 2022 13:34
@fabis94 fabis94 deleted the frontend-viewer-missing-workaround1 branch August 24, 2022 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant