Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(accordion): migration to signals #461

Merged
merged 3 commits into from
Nov 12, 2024

Conversation

marcjulian
Copy link
Contributor

@marcjulian marcjulian commented Nov 9, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

Which package are you modifying?

  • accordion
  • alert
  • alert-dialog
  • aspect-ratio
  • avatar
  • badge
  • button
  • calendar
  • card
  • checkbox
  • collapsible
  • combobox
  • command
  • context-menu
  • data-table
  • date-picker
  • dialog
  • dropdown-menu
  • hover-card
  • icon
  • input
  • label
  • menubar
  • navigation-menu
  • pagination
  • popover
  • progress
  • radio-group
  • scroll-area
  • select
  • separator
  • sheet
  • skeleton
  • slider
  • sonner
  • spinner
  • switch
  • table
  • tabs
  • textarea
  • toast
  • toggle
  • tooltip
  • typography

What is the current behavior?

Closes #432

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@goetzrobin
Copy link
Collaborator

@marcjulian looks good to me! We have a small conflict with imports and LGTM!

# Conflicts:
#	libs/ui/accordion/brain/src/lib/brn-accordion.directive.ts
@marcjulian
Copy link
Contributor Author

@goetzrobin conflicts are resolved

@goetzrobin goetzrobin merged commit a10d2dc into spartan-ng:main Nov 12, 2024
4 checks passed
@marcjulian marcjulian deleted the accordion-signal branch November 12, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor(accordion): migration to signals
2 participants