Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #697 multiple calls to the login API when clicking quickly #698

Merged
merged 1 commit into from
Jan 25, 2025

Conversation

zsdycs
Copy link
Contributor

@zsdycs zsdycs commented Jan 24, 2025

fix #697

@Azir-11
Copy link
Member

Azir-11 commented Jan 24, 2025

可以重新提一个pr,把commit树清理一下

@zsdycs
Copy link
Contributor Author

zsdycs commented Jan 25, 2025

无用的commit内容清理了😄

@honghuangdc
Copy link
Member

commit消息用pnpm commit去生成符合规范的提交
在升级版本的更新日志会用到

@zsdycs
Copy link
Contributor Author

zsdycs commented Jan 25, 2025

嗯,好了,这个message怎么样?

@honghuangdc honghuangdc merged commit 86da767 into soybeanjs:main Jan 25, 2025
honghuangdc added a commit that referenced this pull request Feb 11, 2025
@honghuangdc
Copy link
Member

revert 15163d7

经过考虑,这个还是不加上更好,其他账号登录本身就是一个示例,而且加了这个后会导致一个loading变量控制了四个按钮,在交互上特别奇怪
截屏2025-02-12 00 00 23

@skyfeiz
Copy link
Contributor

skyfeiz commented Feb 18, 2025

image
确认按钮使用loading, 其他账号登录按钮使用disabled,这个方案怎么样?elp使用的这个方案。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: 多次点击“其他账号”按钮登录时,将调用多次API
4 participants