Deprecate Spree::Deprecation in favor of Spree.deprecator
#5289
+108
−90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
changelog:solidus_backend
elia
force-pushed
the
kennyadsl/deprecation-updates
branch
from
798f565 to
6913c87
Compare
elia
force-pushed
the
kennyadsl/deprecation-updates
branch
from
6913c87 to
d7b817b
Compare
github-actions
bot
added
the
changelog:repository
elia
changed the title
Spree::Deprecation in favor of Spree.deprecator
elia
removed
the
changelog:repository
jarednorman
reviewed
Sep 26, 2023
elia
force-pushed
the
kennyadsl/deprecation-updates
branch
from
d7b817b to
d928053
Compare
github-actions
bot
added
the
changelog:repository
elia
force-pushed
the
kennyadsl/deprecation-updates
branch
from
d928053 to
fddb31f
Compare
See https://github.com/rails/rails/blob/814f8ee068814e3d4832a607f49f155e02a609c0/activesupport/lib/active_support/deprecation.rb#L6-L34 Add Spree.deprecator to the list of app deprecators as suggested by Rails, this will allow applying the global deprecation configurations to our engine deprecations as well. Eg: config.active_support.deprecation = :raise This will set the deprecation behavior to raise an exception on any of the deprecators under `Rails.application.deprecators`.
Use autoload to print a deprecation only if the constant is loaded.
elia
force-pushed
the
kennyadsl/deprecation-updates
branch
from
fddb31f to
a7dd17b
Compare
elia
added
changelog:repository
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
After rails/rails#47354, the suggested usage of ActiveSupport::Deprecation has changed and this PR changes our code to reflect that.
TODO:
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: