Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional logging #819

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Additional logging #819

wants to merge 1 commit into from

Conversation

benjben
Copy link
Contributor

@benjben benjben commented Oct 4, 2023

Additional DEBUG logs:

  • Log the size of the biggest event of a chunk (an event being a collector payload that can contain several actual events)
  • Log how many events a collector payload contains

For each event (identified by event_id):

  • Log when the contexts are going to be validated
  • Log when the contexts have been validated
  • Log when the enrichments are going to be executed
  • Log when the enrichments have been executed
  • Log when the contexts added by the enrichments are going to be validated
  • Log when the contexts added by the enrichments have been validated

Copy link
Contributor

@peel peel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is going to be massively costly in a high volume pipeline, but let's try it.

@benjben
Copy link
Contributor Author

benjben commented Oct 4, 2023

Yeah way too costly. I removed the lines that are per event to keep only the ones that are by chunk and by collector payload

@spenes spenes force-pushed the develop branch 2 times, most recently from 29f2672 to 4c373e9 Compare November 15, 2023 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants