Flatten shapes when fetching with Model.shape #269
Conversation
alextwoods
changed the title
gems/smithy/lib/smithy/model.rb
Outdated
| def preprocess(model) | ||
| # TODO: Deep dup of model | ||
| model['shapes'].each do |id, shape| | ||
| flatten_shape(id, model, shape) |
There was a problem hiding this comment.
Since we are flattening the shape here (bringing members and its traits from the mixin shape and applying to this specific shape), do we keep around the mixin shape?
I'm guessing once all the shapes that uses mixins are resolved - the shapes that are marked with mixins are not quite useful since they already fulfilled their purpose. I'm not sure if we opt to remove them or skip over them during codegeneration (check if mixin trait is applied, etc)
There was a problem hiding this comment.
Oh yeah, thats actually a good point. The flattten_shape ends up removing the mixin property of shapes that has flattened, but the shapes themselves remain on the model. Probably makes sense to remove those mixins as well. In theory they shouldn't get picked up when we're using the service shape closure, but they could be picked up if we don't have a service (depending on how we end up implementing that down the road).
mullermp
changed the title
Description of changes:
Demo of option 1 - implementing a preprocess for the model that is applied during plan initialization and which flattens mixins and applies.
TODO: This does NOT correctly handle trait and member order. The prioritization logic of merge is correct, but the resulting order of items is not. We may need to implement our own merge method.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.