style: Improve block styles #13564
Merged
style: Improve block styles #13564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
TCOTC
commented
Dec 20, 2024
•
TCOTC
commented
- 统一各种块的 margin 和 padding ，排版效果更一致，减少 .dragover 样式的抖动
- 列表项竖线增加的 4px 是子块之间的 margin ，多数情况下能使竖线的顶部对齐列表项的第二个子块（底部已经对齐了最后一个子块）
比如用 CSS 实现界面字号与编辑器字号同步调整
body > #dockBottom, body > .fn__flex-1 {
font-size: calc(var(--b3-font-size-editor) - 2px);
}
|
另外在两个块之间移动的时候会出现闪烁，这个我解决不了。 我猜是 .dragover__bottom 和 .dragover__top 的样式没有完美衔接上，中间会出现一瞬间没有 box-shadow 样式。 不知道能不能在下一个 .dragover 添加之后再移除上一个 .dragover 虽然录屏完全看不出来，但这样来回晃就能复现： video.webm |
|
好像不会这样，是不是修改后出现的？ Jietu20241228-212657-HD.mp4 |
|
在 Windows 试试 |
|
我这里 Windows 上测试： issue.webm |
|
不好说，我的屏幕 120Hz 但录屏最高只有 60 Hz，看不到闪烁。 不过这个问题跟我的修改没有关系，改之前就有。 |
|
目前会闪烁，但是不会上下移动。 |
|
我这里刚刚试了一下，也不会上下移动。前面我的录屏不知道为什么会动 |
|
我发现一个问题，现在没法把一个块插入到两个超级块之间： video.webm |
|
这个应该从没有内边距开始就无法插入了 https://ld246.com/article/1631023972971 |
|
@Vanessa219 有空 review 一下 |
|
有些地方有问题，进行了一下修改。 |
|
@Vanessa219 标题块需要这个： 否则会抖动： video.webm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.