Avoid creating multiple instances of DefaultTheme
.
#380
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
UIColor(named:in:compatibleWith:)
initializer method loads colors from the module's resource file on a global queue. Classes likeLineController
in the Runestone project create multiple instances ofDefaultTheme
during initialization, causing a large number ofUIColor
construction tasks to be allocated on the global queue. This can lead to noticeable lag, especially for larger texts, and prevent the editor from properly releasing memory when exiting.The changes made in this pull request are as follows:
Then replace most occurrences of
DefaultTheme()
in the framework withDefaultTheme.share
.