Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set(main) : 폴더 구조 및 yml 설정 #8

Merged
merged 3 commits into from
Dec 27, 2023
Merged

set(main) : 폴더 구조 및 yml 설정 #8

merged 3 commits into from
Dec 27, 2023

Conversation

Woongbin06
Copy link
Contributor

@Woongbin06 Woongbin06 commented Dec 27, 2023 •
edited
Loading

🎫 관련 이슈

close #7


📄 개요

폴더 구조와 application.yml 설정을 했습니다.


🔨 작업 내용

  • 폴더 구조 세팅을 했습니다.
  • application.yml을 작성했습니다.

🏁 확인 사항

  • 테스트를 완료했나요?
  • API 문서를 작성했나요?
  • 코드 컨벤션을 준수했나요?
  • 불필요한 로그, 주석, import 등을 삭제했나요?

🙋🏻 덧붙일 말

@Woongbin06 Woongbin06 linked an issue Dec 27, 2023 that may be closed by this pull request
폴더 구조 세팅 #7
Closed
3 tasks
@Woongbin06 Woongbin06 requested a review from jacobhboy December 27, 2023 01:09
@Woongbin06 Woongbin06 added the 새기능 새로운 기능을 만들어야 해요! label Dec 27, 2023
@Woongbin06 Woongbin06 changed the title Set/#7 set(main) : 폴더 구조 및 yml 설정 Dec 27, 2023
jacobhboy
jacobhboy reviewed Dec 27, 2023
View reviewed changes
src/main/resources/application.yml Outdated
Comment on lines 22 to 28
format_sql: true
show_sql: true

decorator:
datasource:
p6spy:
enable-logging: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

어느 범위까지 SQL 로깅을 하고자 고민했나요?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

디버깅 범위까지 로깅 하고자 했습니다. 디버깅까지만 해도 충분히 이해할 수 있고 트레이스 범위까지 하면 로그가 복잡해질 것 같습니다.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

각각

show_sql: true - 1
decorator:
datasource:
p6spy:
enable-logging: true - 2

1과 2를 다 해주는 이유를 모르겠어요. 목적이 무엇인가요?

Copy link
Contributor Author

@Woongbin06 Woongbin06 Dec 27, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

전체적인 디비 로그를 남길려고 했는데 1은 삭제 하겠습니다.

@jacobhboy jacobhboy self-requested a review December 27, 2023 01:18
jacobhboy
jacobhboy approved these changes Dec 27, 2023
View reviewed changes
Copy link
Member

@jacobhboy jacobhboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굳굳

@Woongbin06 Woongbin06 merged commit f1dfbe9 into master Dec 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobhboy jacobhboy jacobhboy approved these changes

Assignees

@Woongbin06 Woongbin06

Labels
새기능 새로운 기능을 만들어야 해요!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

폴더 구조 세팅
2 participants
@Woongbin06 @jacobhboy