Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

자신의 프로필 조회 #79

Merged
merged 1 commit into from
Feb 20, 2024
Merged

자신의 프로필 조회 #79

merged 1 commit into from
Feb 20, 2024

Conversation

jacobhboy
Copy link
Member

🎫 관련 이슈

close #78


🔨 작업 내용

  • 자신의 프로필을 조회하는 기능을 개발하였습니다.

🏁 확인 사항

  • 테스트를 완료했나요?
  • API 문서를 작성했나요?
  • 코드 컨벤션을 준수했나요?
  • 불필요한 로그, 주석, import 등을 삭제했나요?

🙋🏻 덧붙일 말

@jacobhboy jacobhboy requested a review from Woongbin06 February 16, 2024 09:32
@jacobhboy jacobhboy linked an issue Feb 16, 2024 that may be closed by this pull request
2 tasks
Copy link
Contributor

@Woongbin06 Woongbin06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굳굳 수고하셨습니다~

Comment on lines +67 to +70
@LoginRequired
@ResponseStatus(HttpStatus.OK)
public ProfileResponse readMine() {
User currentUser = authRepository.getCurrentUser();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리스폰스로 DTO를 넘겨줘서 굳이 HTTP 상태를 안넘겨줘도 될 것 같아요!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

명시적인 것도 좋은 것 같습니다!!

@jacobhboy jacobhboy merged commit ecec422 into master Feb 20, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

자신의 프로필 조회
2 participants