이미지 도메인 추가 및 이미지 저장 #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Woongbin06
suggested changes
Feb 19, 2024
Comment on lines
11
to
18
| @Entity | ||
| @Getter | ||
| @NoArgsConstructor(access = AccessLevel.PROTECTED) | ||
| public class Image { | ||
| @Id | ||
| @GeneratedValue(strategy = GenerationType.IDENTITY) | ||
| private Long id; | ||
| private String fileName; |
There was a problem hiding this comment.
s3에 저장된 이미지와 image객체의 생명주기를 똑같이 관리하려고 저렇게 구현했는데, 중간에 방법이 바뀌면서 필요없게 되었네요! 삭제하는 편이 좋을 것 같습니다.
Comment on lines
19
to
21
| public void delete(Long id) { | ||
| Image byId = imageRepository.getById(id); | ||
| amazonS3.deleteObject(s3Bucket.getS3Bucket(), byId.getFileName()); |
There was a problem hiding this comment.
Image 객체 이름이 byId보단 image가 좋을 거 같아요
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 관련 이슈
close #74
🔨 작업 내용
🏁 확인 사항
🙋🏻 덧붙일 말