Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

커피챗 기능 개발 #49

Merged
merged 39 commits into from
Jan 29, 2024
Merged

커피챗 기능 개발 #49

merged 39 commits into from
Jan 29, 2024

Conversation

Woongbin06
Copy link
Contributor

🎫 관련 이슈

close #38


📄 개요

커피챗 기능을 만들었습니다.


🔨 작업 내용

  • 커피챗 제안 기능
  • 커피챗 거절 기능
  • 커피챗 수락 기능

🏁 확인 사항

  • 테스트를 완료했나요?
  • API 문서를 작성했나요?
  • 코드 컨벤션을 준수했나요?
  • 불필요한 로그, 주석, import 등을 삭제했나요?

🙋🏻 덧붙일 말

jacobhboy and others added 30 commits January 8, 2024 09:01
@Woongbin06 Woongbin06 linked an issue Jan 26, 2024 that may be closed by this pull request
4 tasks
@Woongbin06 Woongbin06 requested a review from jacobhboy January 26, 2024 13:15
Copy link
Member

@jacobhboy jacobhboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굳굳~! 수고하셨습니다~ 저거 id name만 수정 부탁드릴게요!


@Id
@GeneratedValue(strategy = GenerationType.IDENTITY)
@Column(name = "coffeeChat_id")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

카멜케이스와 스네이크 케이스를 혼용해서 사용했어요!

Comment on lines +28 to +45
public void create(CoffeeChat coffeeChat, Long toUserId) {
User toUser = userReader.readUser(toUserId);
coffeeChat.updateToUser(toUser);
coffeeChatCreator.create(coffeeChat);
}

public void accept(User user, Long coffeeChatId) {
CoffeeChat coffeeChat = coffeeChatReader.read(coffeeChatId);
coffeeChatValidator.shouldBeSameUser(user, coffeeChat.getToUser());
coffeeChatValidator.shouldBePending(coffeeChat);
coffeeChatUpdater.updateState(coffeeChat, State.ACCEPT);
}

public void reject(User user, Long coffeeChatId) {
CoffeeChat coffeeChat = coffeeChatReader.read(coffeeChatId);
coffeeChatValidator.shouldBeSameUser(user, coffeeChat.getToUser());
coffeeChatValidator.shouldBePending(coffeeChat);
coffeeChatUpdater.updateState(coffeeChat, State.REJECT);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

다 깔끔하고 너무 좋은 것 같습니다 🥹

@Woongbin06 Woongbin06 requested a review from jacobhboy January 29, 2024 09:21
Copy link
Member

@jacobhboy jacobhboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굳굳~

@Woongbin06 Woongbin06 merged commit 08866d8 into master Jan 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

커피챗 기능 개발
2 participants