관심 없음 기능 추가 #47
Merged
관심 없음 기능 추가 #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
1 task
Woongbin06
suggested changes
Jan 26, 2024
Comment on lines
+21
to
+23
|
|
||
| Long userId; | ||
| Long partyId; |
There was a problem hiding this comment.
관심없음과 관련해서는 graphQL 복잡한 쿼리만 날아가는데 그럴 때에는 ID만 매핑하고 쓰는게 훨씬 편하더라구요. 사실 이것보다 저거 두개 복합키로 쓰려고 했는데 따로 클래스 빼자고 하니, 필드가 ID하나인 객체가 만들어져서 일단 저렇게 했습니다 😃
| } | ||
|
|
||
| public void shouldNotAlreadyNotInterested(User user, Long partyId, Type partyType) { | ||
| boolean isAlreadyExist = notInterestedRepository.existsByUserIdAndPartyIdAndPartyType(user.getId(), partyId, |
There was a problem hiding this comment.
메소드 네이밍이 길어지면 디폴트 메소드로 줄일 수도 있을 것 같아요!!
There was a problem hiding this comment.
저거 레파지토리의 메소드 네이밍 말한거였어요!!
Comment on lines
+22
to
+24
| private final CommandInterestService commandInterestService; | ||
| private final AuthReader authReader; | ||
|
|
There was a problem hiding this comment.
생각을 해보니 Reader는 서비스에서 사용하는 구현체라 프레젠테이션에서 바로 쓰지 말고 서비스를 구현해서 사용하는 게 어떤가요????
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 관련 이슈
close #46
🔨 작업 내용
🏁 확인 사항
🙋🏻 덧붙일 말