Token 처리하는 필터 구현 #41
Merged
Token 처리하는 필터 구현 #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
2 tasks
Woongbin06
approved these changes
Jan 11, 2024
Comment on lines
+12
to
+15
| public class UserCreator { | ||
|
|
||
| private final UserRepository repository; | ||
|
|
There was a problem hiding this comment.
repository 네이밍을 통일성 있게 가기 위해서 userRepository로 하는게 좋을 거 같아요
Comment on lines
+36
to
+37
| User user = userRepository.findById(userId) | ||
| .orElseThrow(() -> new UserNotFoundException(userId)); |
There was a problem hiding this comment.
인터셉터에서는 userReader를 만들어서 쓸 수 없는 건가요?? 진짜 몰라서 물어봅니다. ㅎ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 관련 이슈
close #40
🔨 작업 내용
🏁 확인 사항
🙋🏻 덧붙일 말