feat(like) : 좋아요 기능 개발 #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
2 tasks
jacobhboy
requested changes
Jan 7, 2024
Comment on lines
28
to
38
| public void createLike(Long qnAId, User user) { | ||
| QnA qnA = qnAReader.read(qnAId); | ||
| likeValidator.shouldBeAlreadyLike(qnA, user); | ||
| likeCreator.create(new Like(user, qnA)); | ||
| } | ||
|
|
||
| public void deleteLike(Long qnAId, User user) { | ||
| QnA qnA = qnAReader.read(qnAId); | ||
| Like like = likeReader.read(qnA, user); | ||
| likeDeleter.delete(like); | ||
| } |
There was a problem hiding this comment.
LikeService니 함수이름을 creatLike로 하는 것 보다 create와 같이 작성하는게 간결해보입니다!
Comment on lines
18
to
24
| public void shouldBeAlreadyLike(QnA qnA, User user) { | ||
| boolean isExist = likeRepository.existsByQnAAndUser(qnA, user); | ||
|
|
||
| if (isExist) { | ||
| throw new AlreadyLikeException(); | ||
| } | ||
| } |
There was a problem hiding this comment.
shouldBeAlreadyLike라는 함수 이름이 잘못된 것 같아요. 이 메서드는 좋아요가 이미 눌러져있다면 오류를 발행하는 함수이기 때문에 shouldNotExistLike 와 같은 이름이 적합해보입니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 관련 이슈
close #36
📄 개요
🔨 작업 내용
🏁 확인 사항
🙋🏻 덧붙일 말