Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(linter): linter 및 git hook pre-commit, CI 적용 #10

Merged
merged 4 commits into from
Dec 27, 2023
Merged

ci(linter): linter 및 git hook pre-commit, CI 적용 #10

merged 4 commits into from
Dec 27, 2023

Conversation

jacobhboy
Copy link
Member

@jacobhboy jacobhboy commented Dec 27, 2023 •
edited
Loading

🎫 관련 이슈

close #9


📄 개요


🔨 작업 내용

  • java linter 추가
  • pre-commit 시 메인 코드 혹은 테스트 코드가 컨벤션에 부합하지 않을 시 커밋 실패
  • 강제 커밋을 한 경우를 막기 위해서 ci 작업으로 lint 확인

🏁 확인 사항

  • 테스트를 완료했나요?
  • API 문서를 작성했나요?
  • 코드 컨벤션을 준수했나요?
  • 불필요한 로그, 주석, import 등을 삭제했나요?

🙋🏻 덧붙일 말

@jacobhboy jacobhboy linked an issue Dec 27, 2023 that may be closed by this pull request
linter 적용 #9
Closed
3 tasks
@jacobhboy jacobhboy changed the title Feat/#9 ci(linter): linter 및 git hook pre-commit, CI 적용 Dec 27, 2023
@jacobhboy jacobhboy requested a review from Woongbin06 December 27, 2023 02:08
@jacobhboy jacobhboy merged commit 9948f0c into master Dec 27, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Woongbin06 Woongbin06 Woongbin06 approved these changes

Assignees

@jacobhboy jacobhboy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

linter 적용
2 participants
@jacobhboy @Woongbin06