-
Notifications
You must be signed in to change notification settings - Fork 89
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
This moves the specs to the directories suggested in #1001, updates them to use get-function(), and documents the exact issues that they're testing. It also updates the output of one of them to be an error, which is expected.
- Loading branch information
Showing
11 changed files
with
39 additions
and
25 deletions.
There are no files selected for viewing
File renamed without changes.
13 changes: 13 additions & 0 deletions
13
spec/core_function/meta/call/regression/arglist_is_valid/input.scss
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
// Regression test for sass/libsass#2472 | ||
// | ||
// Passing an argument list to `call()` was broken on LibSass. The call to | ||
// `dark()` throw an error complaining about the second argument being the wrong | ||
// type. | ||
|
||
@function dark($color, $args...) { | ||
@return call(get-function('darken'), $color, $args...); | ||
} | ||
|
||
.test { | ||
wrong-type: dark(#102030, 5%); | ||
} |
5 changes: 5 additions & 0 deletions
5
spec/core_function/meta/call/regression/arglist_triggers_argument_error/error
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
Error: Only one positional argument is allowed. All other arguments must be passed by name. | ||
@return call(get-function('adjust-color'), $color, $args...); | ||
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | ||
/sass/spec/core_function/meta/call/regression/arglist_triggers_argument_error/input.scss 9:11 adjust() | ||
/sass/spec/core_function/meta/call/regression/arglist_triggers_argument_error/input.scss 13:12 root stylesheet |
3 changes: 3 additions & 0 deletions
3
spec/core_function/meta/call/regression/arglist_triggers_argument_error/error-ruby-sass
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
Error: -5 is not a keyword argument for `adjust_color' | ||
on line 9 of /sass/spec/core_function/meta/call/regression/arglist_triggers_argument_error/input.scss | ||
Use --trace for backtrace. |
Empty file.
14 changes: 14 additions & 0 deletions
14
spec/core_function/meta/call/regression/arglist_triggers_argument_error/input.scss
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
// Regression test for sass/libsass#2472 | ||
// | ||
// Passing an argument list to `call()` was broken on LibSass. The call to | ||
// `adjust()` should throw an error complaining about passing -5 by position | ||
// instead of by name, but in LibSass it threw an error complaining about "not | ||
// enough arguments". | ||
|
||
@function adjust($color, $args...) { | ||
@return call(get-function('adjust-color'), $color, $args...); | ||
} | ||
|
||
.test { | ||
too-few: adjust(#102030, -5); | ||
} |
3 changes: 3 additions & 0 deletions
3
spec/core_function/meta/call/regression/arglist_triggers_argument_error/options.yml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
--- | ||
:todo: | ||
- libsass # sass/libsass#2696 |
1 change: 1 addition & 0 deletions
1
spec/core_function/meta/call/regression/arglist_triggers_argument_error/status
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
65 |
3 changes: 0 additions & 3 deletions
3
spec/libsass-todo-issues/issue_2472/number/expected_output.css
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.