Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: invalid locale namespace specified for create #7732

Merged
merged 1 commit into from
Nov 4, 2024
Merged

fix: invalid locale namespace specified for create #7732

merged 1 commit into from
Nov 4, 2024

Conversation

rexxars
Copy link
Member

@rexxars rexxars commented Nov 3, 2024

Description

The namespace was incorrectly specified for the new create strings, which causes issues for the locales repository, as it clobbers the comments namespace.

What to review

Should be pretty obvious ;)

Testing

Shouldn't be needed.

Notes for release

None.

@rexxars rexxars requested review from snorrees and a team November 3, 2024 18:44
@vercel Vercel
Copy link

vercel bot commented Nov 3, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 3, 2024 7:27pm
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 3, 2024 7:27pm
test-compiled-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 3, 2024 7:27pm
test-next-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 3, 2024 7:27pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 3, 2024 7:27pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Nov 3, 2024 7:27pm

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 3, 2024

No changes to documentation

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 3, 2024 •
edited
Loading

Component Testing Report Updated Nov 3, 2024 7:20 PM (UTC)

❌ Failed Tests (1) -- expand for details
File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 52s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 8s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 32s 6 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 39s 11 7 0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx ✅ Passed (Inspect) 0s 0 12 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 18s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 10s 3 0 0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ✅ Passed (Inspect) 3m 0s 0 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 46s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 49s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 18s 18 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 9s 3 9 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 27s 9 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 18s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ❌ Failed (Inspect) 47s 11 0 1
formBuilder/tree-editing/TreeEditing.spec.tsx ✅ Passed (Inspect) 0s 0 3 0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx ✅ Passed (Inspect) 0s 0 3 0

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 3, 2024 •
edited
Loading

⚡️ Editor Performance Report

Updated Sun, 03 Nov 2024 19:21:46 GMT

Benchmark reference
latency of sanity@latest		 experiment
latency of this branch		 Δ (%)
latency difference
article (title) 17.9 efps (56ms) 17.7 efps (57ms) +1ms (+0.9%) ✅
article (body) 56.5 efps (18ms) 63.7 efps (16ms) -2ms (-11.3%) ✅
article (string inside object) 18.9 efps (53ms) 19.2 efps (52ms) -1ms (-1.9%) ✅
article (string inside array) 16.0 efps (63ms) 16.1 efps (62ms) -1ms (-0.8%) ✅
recipe (name) 30.3 efps (33ms) 30.3 efps (33ms) +0ms (-/-%) ✅
recipe (description) 34.5 efps (29ms) 34.5 efps (29ms) +0ms (-/-%) ✅
recipe (instructions) 99.9+ efps (6ms) 99.9+ efps (6ms) +0ms (-/-%) ✅
synthetic (title) 14.8 efps (68ms) 14.4 efps (70ms) +2ms (+3.0%) ✅
synthetic (string inside object) 15.2 efps (66ms) 15.2 efps (66ms) +0ms (-/-%) ✅

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 56ms 61ms 73ms 223ms 421ms 12.7s
article (body) 18ms 20ms 29ms 274ms 303ms 5.8s
article (string inside object) 53ms 58ms 68ms 232ms 428ms 8.6s
article (string inside array) 63ms 69ms 80ms 355ms 748ms 9.6s
recipe (name) 33ms 35ms 40ms 71ms 0ms 8.7s
recipe (description) 29ms 31ms 34ms 58ms 0ms 5.7s
recipe (instructions) 6ms 8ms 8ms 11ms 0ms 3.2s
synthetic (title) 68ms 72ms 90ms 370ms 1365ms 15.9s
synthetic (string inside object) 66ms 73ms 88ms 440ms 1015ms 9.8s

🧪 Experiment result

The performance result of this branch

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 57ms 60ms 68ms 138ms 391ms 13.0s
article (body) 16ms 18ms 21ms 95ms 166ms 5.2s
article (string inside object) 52ms 55ms 61ms 221ms 245ms 8.3s
article (string inside array) 62ms 67ms 77ms 178ms 784ms 9.4s
recipe (name) 33ms 36ms 42ms 87ms 3ms 9.9s
recipe (description) 29ms 31ms 40ms 65ms 2ms 5.9s
recipe (instructions) 6ms 8ms 8ms 10ms 0ms 3.3s
synthetic (title) 70ms 74ms 82ms 310ms 1497ms 15.1s
synthetic (string inside object) 66ms 70ms 78ms 332ms 1182ms 10.0s

📚 Glossary

column definitions

  • benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".
  • latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.
  • p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.
  • p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.
  • p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.
  • blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.
  • test duration — how long the test run took to complete.

@rexxars rexxars force-pushed the fix/invalid-locale-definition branch from 837cb70 to 9a872ff Compare November 3, 2024 19:09
@rexxars rexxars requested review from a team and ricokahler and removed request for a team November 4, 2024 17:02
binoy14
binoy14 approved these changes Nov 4, 2024
View reviewed changes
Copy link
Contributor

@binoy14 binoy14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me, thanks!

@rexxars rexxars added this pull request to the merge queue Nov 4, 2024
Merged via the queue into next with commit 9b2a6f7 Nov 4, 2024
67 checks passed
@rexxars rexxars deleted the fix/invalid-locale-definition branch November 4, 2024 17:43
bjoerge added a commit that referenced this pull request Nov 5, 2024
@bjoerge
Merge branch 'next' into corel
49310e8 
* next:
  chore(deps): dedupe pnpm-lock.yaml (#7752)
  chore(deps): update react monorepo (#7753)
  fix(deps): update dependency react-rx to ^4.1.3 (#7744)
  fix(deps): update dependency @sanity/ui to ^2.8.19 (#7742)
  fix(deps): update dependency @portabletext/editor to ^1.5.4 (#7737)
  fix(deps): update dependency @sanity/presentation to v1.17.8 (#7743)
  test(codegen): migrate codegen tests to vitest (#7741)
  fix: invalid locale namespace specified for create (#7732)
  chore(deps): update dependency @sanity/prettier-config to ^1.0.3 (#7733)
  fix(deps): update dependency react-rx to ^4.1.1 (#7739)
  fix(deps): update dependency groq-js to ^1.14.0 (#7738)
  test(cli): migrate cli tests to vitest (#7731)
  fix(core): export BetaFeatures and ScheduledPublishing types (#7659)
  chore(test-studio): update dependency @portabletext/editor to ^1.4.1 (#7734)
  fix(deps): update dependency @portabletext/editor to ^1.4.1 (#7735)
  fix(deps): update dependency @portabletext/editor to ^1.4.0 (#7729)
  fix(deps): update dependency @sanity/ui to ^2.8.18 (#7730)
  fix(deps): Update dev-non-major (#7724)
  fix(deps): update dependency @sanity/ui to ^2.8.17 (#7725)
  fix(deps): update dependency @portabletext/editor to ^1.3.0 (#7727)
jordanl17 pushed a commit that referenced this pull request Nov 5, 2024
@rexxars @jordanl17
fix: invalid locale namespace specified for create (#7732)
aacd548
bjoerge added a commit that referenced this pull request Nov 5, 2024
@bjoerge
Merge branch 'next' into corel
9745162 
* next: (49 commits)
  v3.63.0
  chore(scripts): reordering blocks in release notes template script (#7758)
  chore(deps): update dependency babel-plugin-react-compiler to v19 (#7755)
  fix(deps): Update dev-non-major (#7736)
  chore(deps): dedupe pnpm-lock.yaml (#7752)
  chore(deps): update react monorepo (#7753)
  fix(deps): update dependency react-rx to ^4.1.3 (#7744)
  fix(deps): update dependency @sanity/ui to ^2.8.19 (#7742)
  fix(deps): update dependency @portabletext/editor to ^1.5.4 (#7737)
  fix(deps): update dependency @sanity/presentation to v1.17.8 (#7743)
  test(codegen): migrate codegen tests to vitest (#7741)
  fix: invalid locale namespace specified for create (#7732)
  chore(deps): update dependency @sanity/prettier-config to ^1.0.3 (#7733)
  fix(deps): update dependency react-rx to ^4.1.1 (#7739)
  fix(deps): update dependency groq-js to ^1.14.0 (#7738)
  test(cli): migrate cli tests to vitest (#7731)
  fix(core): export BetaFeatures and ScheduledPublishing types (#7659)
  chore(test-studio): update dependency @portabletext/editor to ^1.4.1 (#7734)
  fix(deps): update dependency @portabletext/editor to ^1.4.1 (#7735)
  fix(deps): update dependency @portabletext/editor to ^1.4.0 (#7729)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@binoy14 binoy14 binoy14 approved these changes

@snorrees snorrees Awaiting requested review from snorrees

@ricokahler ricokahler Awaiting requested review from ricokahler ricokahler was automatically assigned from sanity-io/sdk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rexxars @binoy14