feat(structure): History UI updates #7462
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
|
No changes to documentation |
|
Component Testing Report Updated Nov 7, 2024 5:35 PM (UTC) ❌ Failed Tests (1) -- expand for details
|
pedrobonamin
force-pushed
the
history-updates
branch
from
4b07286
to
39792f5
Compare
pedrobonamin
force-pushed
the
history-updates
branch
from
39792f5
to
17e81d0
Compare
* feat(sanity): update restore button * chore(sanity): update translations * feat(sanity): add left side information on footer (revision status line)
…el (#7435) * feat(structure): add history and review tabs to changes inspector panel * fix(structure): move changes inspector navigation to paneRouter * fix(structure): update isReviewChangesOpen check in ChangeConnectorRoot * fix(structure): rename uses of version to revision * chore(core): rename review changes action to history
…nks (#7449) * feat(structure): update TimelineItem to match new UI, prepare for chunks * chore(core): export getCalendarLabels to support DateTimeInput reusability
* feat(structure): add squashed chunks to timeline * feat(structure): refactor expandable item, all items need to be rendered in the same virtual list * feat(structure): expand elements on menu click * chore(structure): clean timeline item
pedrobonamin
force-pushed
the
history-updates
branch
from
2e16919
to
eaff9b0
Compare
pedrobonamin
commented
Nov 8, 2024
| @@ -194,7 +194,6 @@ export function useTimelineStore({ | |||
| findRangeForSince: (chunk: Chunk) => controller.findRangeForNewSince(chunk), | |||
| loadMore: () => { | |||
| controller.setLoadMore(true) | |||
| timelineStateRef.current.isLoading = true | |||
There was a problem hiding this comment.
I noticed this in some cases was blocking the ui in a loading state, which never ended because the load more action was not actually fetching new data, so the controller was not triggering any update, so the isLoading returned in line 220 was never resetting to false.
pedrobonamin
commented
Nov 8, 2024
Comment on lines
-114
to
-119
| if (didPublish) { | ||
| if (changesOpen) { | ||
| // Re-open the panel | ||
| onHistoryOpen() | ||
| } | ||
| } |
There was a problem hiding this comment.
This is not necessary, the history panel won't close when a publish action happens.
RitaDias
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces UI changes into the
historyandrevisionpanel.What does "chunks are squashed together on publish" means?
Once the draft changes are published all the draft edits done before that publish will be squashed and shown as 1 change, that could be expanded, showing also the collaborators for that published.
This means:
If we have the following mutations:
[draftEdit, publish, draftEdit, draftEdit, create]it will be shown as
[draftEdit, publish (expandable), create]On expand, it will show the two collapsed draftEdit actions
The changes are not removed from the history, they are only visually squashed for easier navigation in the UI.
This is achieved by creating a relation between parents publish action and children draftEdit actions, in the addChunksMetadata function.
Collapsable.history.items.mov
What to review
Are the changes correct? Is something missing?
Testing
Notes for release
Updates to history inspector UI