feat(facelift): create StudioUI tooltip with delay and replace #5016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
Full Report@sanity/diff
@sanity/block-tools
sanity/desk
@sanity/portable-text-editor
@sanity/mutator
@sanity/cli
@sanity/schema/_internal
@sanity/util/paths
sanity/router
@sanity/util/legacyDateFormat
@sanity/schema
sanity/cli
@sanity/vision
@sanity/util/fs
sanity/_internal
@sanity/util/content
sanity
@sanity/types
|
|
Component Testing Report Updated Oct 26, 2023 1:32 PM (UTC)
|
…oltips with this logic
ninaandal
force-pushed
the
edx-472-revised
branch
from
281ad1a
to
f51396e
Compare
robinpyon
reviewed
Oct 25, 2023
There was a problem hiding this comment.
Thanks @ninaandal – interesting to see exactly how many instances there are (and how much variance there is layout wise).
Upon using it, maybe we'll want to tweak that delay slightly (but this change makes it much easier to do so globally)
Left a minor comment on tooltip styling but otherwise LGTM!
Co-authored-by: Robin Pyon <[email protected]>
robinpyon
force-pushed
the
edx-472-revised
branch
from
b8acec7
to
a15d186
Compare
robinpyon
approved these changes
Oct 26, 2023
robinpyon
added a commit
that referenced
this pull request
Nov 2, 2023
* feat(facelift): create StudioUI tooltip with delay and replace * fix(core/desk): use StudioUi Tooltip * fix(core/desk): use Studio UI tooltip * fix(core/desk): use StudioUI tooltip and remove paddings * fix(core): use StudioUI tooltip for TooltipOfDisabled - ref prop error * fix(src): fix studioUI tooltip to take strings and replace current tooltips with this logic * fix(vision): change tooltip import path * fix(src): fix up content in StudioUI tooltips, remove comment * fix(core): add two arguments to forwardRef render function * fix(test-studio): add custom badge to author schema type * Update packages/sanity/src/ui/tooltip/Tooltip.tsx Co-authored-by: Robin Pyon <[email protected]> * refactor: slightly DRY tooltip component --------- Co-authored-by: Robin Pyon <[email protected]> Co-authored-by: Robin Pyon <[email protected]>
robinpyon
added a commit
that referenced
this pull request
Nov 3, 2023
* feat(facelift): create StudioUI tooltip with delay and replace * fix(core/desk): use StudioUi Tooltip * fix(core/desk): use Studio UI tooltip * fix(core/desk): use StudioUI tooltip and remove paddings * fix(core): use StudioUI tooltip for TooltipOfDisabled - ref prop error * fix(src): fix studioUI tooltip to take strings and replace current tooltips with this logic * fix(vision): change tooltip import path * fix(src): fix up content in StudioUI tooltips, remove comment * fix(core): add two arguments to forwardRef render function * fix(test-studio): add custom badge to author schema type * Update packages/sanity/src/ui/tooltip/Tooltip.tsx Co-authored-by: Robin Pyon <[email protected]> * refactor: slightly DRY tooltip component --------- Co-authored-by: Robin Pyon <[email protected]> Co-authored-by: Robin Pyon <[email protected]>
robinpyon
added a commit
that referenced
this pull request
Nov 8, 2023
* feat(facelift): create StudioUI tooltip with delay and replace * fix(core/desk): use StudioUi Tooltip * fix(core/desk): use Studio UI tooltip * fix(core/desk): use StudioUI tooltip and remove paddings * fix(core): use StudioUI tooltip for TooltipOfDisabled - ref prop error * fix(src): fix studioUI tooltip to take strings and replace current tooltips with this logic * fix(vision): change tooltip import path * fix(src): fix up content in StudioUI tooltips, remove comment * fix(core): add two arguments to forwardRef render function * fix(test-studio): add custom badge to author schema type * Update packages/sanity/src/ui/tooltip/Tooltip.tsx Co-authored-by: Robin Pyon <[email protected]> * refactor: slightly DRY tooltip component --------- Co-authored-by: Robin Pyon <[email protected]> Co-authored-by: Robin Pyon <[email protected]>
robinpyon
added a commit
that referenced
this pull request
Nov 18, 2023
* feat(facelift): create StudioUI tooltip with delay and replace * fix(core/desk): use StudioUi Tooltip * fix(core/desk): use Studio UI tooltip * fix(core/desk): use StudioUI tooltip and remove paddings * fix(core): use StudioUI tooltip for TooltipOfDisabled - ref prop error * fix(src): fix studioUI tooltip to take strings and replace current tooltips with this logic * fix(vision): change tooltip import path * fix(src): fix up content in StudioUI tooltips, remove comment * fix(core): add two arguments to forwardRef render function * fix(test-studio): add custom badge to author schema type * Update packages/sanity/src/ui/tooltip/Tooltip.tsx Co-authored-by: Robin Pyon <[email protected]> * refactor: slightly DRY tooltip component --------- Co-authored-by: Robin Pyon <[email protected]> Co-authored-by: Robin Pyon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Starting the work of Studio UI - this PR adds the StudioUI tooltip with an globally added
delay, but passes on the otherprops.Since the StudioUI tooltuip now have a default
padding, this PR also removes the paddings added to the tooltips for consistency.What to review
Since this PR changes all tooltips in the studio, all of them should be properly tested to make sure they are looking as they should
Adding some videos to show where many of the tooltips can be found:
Screen.Recording.2023-10-24.at.20.45.40.mov
Screen.Recording.2023-10-24.at.20.45.10.mov
Screen.Recording.2023-10-24.at.20.47.49.mov
Screen.Recording.2023-10-24.at.20.53.46.mov
Notes for release