Align previous/next page flag with relay standard. #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution. |
|
@yanns Thanks for the FYI. I've addressed the incompatibilities. 🙇🏾♂️ |
yanns
approved these changes
Apr 24, 2023
Co-authored-by: Yann Simon <[email protected]>
|
Does this PR fix #35? |
|
And #11? |
|
Thanks a lot for the help!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to graphql/graphql-relay-js#58 and bi-directional pagination.
I know that the changes in
Connection.connectionFromSeqare kind of cumbersome so any help on improving those would be very much appreciated.Also, I tried to document why the changes in the tests with small comments just to clarify (and honestly, those comments helped me to debug the offsets computations).
Thanks in advance.