Migrate meilisearch to Chart dependency #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'll leave this up to ya'll - I wasn't sure if meilisearch was specifically bundled.
Rather than bundling meilisearch with the full repo, we'll use helm's built-in dependency resolution. This adds a little complexity -
helm dependency updateon user scripts, andhelm dependency buildto update it.On the bright side, it means updating now is a version bump in
Chart.yaml/ possible via dependabot. Again, I'll leave this up to ya'll if you want this - I can understand it being a toss up.