Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repo Auth / Middleware #5

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jtdroste
Copy link

(This is PR #4 - just correctly branched)

This PR adds two changes:

  • Adds a new value scot4.common.imagePullSecrets. This accepts a kubernetes secret, to be used when pulling images. To preserve backward compatibility, the previous value has been set here. If you set this value to empty, then imagePullSecrets is removed from all deployments.
  • Adds a new value scot4.frontend.enableTraefikMiddleware (default: true, for BC) and scot4.frontend.traefikMiddlewareVersion (default: traefik.containo.us/v1alpha1 as the previous/BC version). Setting enableTraefikMiddleware to false will disable middleware all together. In addition, you can override the middlewareVersion to the newer traefik CRD traefik.io/v1alpha1 if needed. I'll leave this up to ya'll if you just want to take the latest version.

Testing

Locally, via:

$ helm template scot4 ./scot4 --set scot4.common.imagePullSecret=""
$ helm template scot4 ./scot4 --set scot4.common.imagePullSecret="foobar"
$ helm template scot4 ./scot4 --set scot4.frontend.enableTraefikMiddleware="no"
$ helm template scot4 ./scot4 --set scot4.frontend.enableTraefikMiddleware="traefik.io/v1alpha1"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant