Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(This is PR #4 - just correctly branched)
This PR adds two changes:
scot4.common.imagePullSecrets
. This accepts a kubernetes secret, to be used when pulling images. To preserve backward compatibility, the previous value has been set here. If you set this value to empty, thenimagePullSecrets
is removed from all deployments.scot4.frontend.enableTraefikMiddleware
(default: true, for BC) andscot4.frontend.traefikMiddlewareVersion
(default:traefik.containo.us/v1alpha1
as the previous/BC version). SettingenableTraefikMiddleware
to false will disable middleware all together. In addition, you can override the middlewareVersion to the newer traefik CRDtraefik.io/v1alpha1
if needed. I'll leave this up to ya'll if you just want to take the latest version.Testing
Locally, via: