feat: Create a initial docker container for FIREWHEEL #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Steven Elliott <[email protected]>
sdelliot
commented
Feb 21, 2025
Comment on lines
+3
to
+12
| /usr/share/openvswitch/scripts/ovs-ctl start 1>/var/log/minimega.log 2>/var/log/minimega.log | ||
| if [ $? -ne 0 ]; then | ||
| echo "Failed to start Open vSwitch" 1> /var/log/minimega.log | ||
| fi | ||
|
|
||
| # Check if Minimega is already running | ||
| if pgrep -f "/opt/minimega/bin/minimega" > /dev/null; then | ||
| echo "Minimega is already running. Exiting script." 1> /var/log/minimega.log | ||
| exit 0 | ||
| fi |
There was a problem hiding this comment.
@GhostofGoes and @jacdavi do you think that minimega would benefit from these additions to the start-minimega.sh or do you think it would cause a loss of functionality?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides a working Docker container for FIREWHEEL. We should consider this as a beta-testing phase and remove that label in a future release. This container has been tested in both low-trust and high-trust environments where various permissions/kernel modules were stripped and verified functionality. The associated documentation provides a good overview of the container and how it was created.
Aside from that, there are a few important things to note: